From e027ae93572e9a6f05e3604bc3fbacb1ab4348d4 Mon Sep 17 00:00:00 2001
From: Corentin <corentin@acadenice.fr>
Date: Fri, 8 May 2026 12:41:18 +0200
Subject: [PATCH] =?UTF-8?q?fix(acadenice):=20unwrap=20server=20response=20?=
 =?UTF-8?q?envelope=20in=204=20client=20services=20=E2=80=94=20Patch=20024?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The server applies a global TransformHttpResponseInterceptor that wraps
every response body in { data, success, status }. Native Docmost client
services use the api axios instance whose interceptor already unwraps
once, so callers see r.data === payload directly.

The acadenice client services use axios directly (no interceptor), so
r.data === { data, success, status } envelope. Calling templates.map()
on the envelope crashed <TemplatePickerModal> with 'templates.map is
not a function' — exact symptom Corentin hit (white screen on click).

Patched 4 services to read r.data.data: templates, sync-blocks,
slash-commands, clipper. The notifications service already uses the api
instance so it was untouched.

A future refactor should migrate all 4 to the shared api instance for
consistency and to inherit auth/redirect handling.

Patch 024.
---
 .../acadenice/clipper/services/clipper-client.ts     |  4 ++--
 .../services/slash-commands-client.ts                | 10 +++++-----
 .../sync-blocks/services/sync-blocks-client.ts       |  8 ++++----
 .../templates-admin/services/templates-client.ts     | 12 ++++++------
 4 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/apps/client/src/features/acadenice/clipper/services/clipper-client.ts b/apps/client/src/features/acadenice/clipper/services/clipper-client.ts
index d2647e1f..b1269884 100644
--- a/apps/client/src/features/acadenice/clipper/services/clipper-client.ts
+++ b/apps/client/src/features/acadenice/clipper/services/clipper-client.ts
@@ -24,13 +24,13 @@ export interface CreateTokenResponse {
 
 export const clipperClient = {
   listTokens(): Promise<ClipperTokenInfo[]> {
-    return axios.get<ClipperTokenInfo[]>(`${BASE}/tokens`).then((r) => r.data);
+    return axios.get<ClipperTokenInfo[]>(`${BASE}/tokens`).then((r) => r.data.data);
   },
 
   createToken(payload: CreateTokenPayload): Promise<CreateTokenResponse> {
     return axios
       .post<CreateTokenResponse>(`${BASE}/tokens`, payload)
-      .then((r) => r.data);
+      .then((r) => r.data.data);
   },
 
   revokeToken(tokenId: string): Promise<void> {
diff --git a/apps/client/src/features/acadenice/slash-commands-admin/services/slash-commands-client.ts b/apps/client/src/features/acadenice/slash-commands-admin/services/slash-commands-client.ts
index ef0cce2b..1ed99eff 100644
--- a/apps/client/src/features/acadenice/slash-commands-admin/services/slash-commands-client.ts
+++ b/apps/client/src/features/acadenice/slash-commands-admin/services/slash-commands-client.ts
@@ -39,21 +39,21 @@ const BASE = '/api/acadenice/slash-commands';
 
 export const slashCommandsClient = {
   list(): Promise<SlashCommandDto[]> {
-    return axios.get<SlashCommandDto[]>(BASE).then((r) => r.data);
+    return axios.get<SlashCommandDto[]>(BASE).then((r) => r.data.data);
   },
 
   get(id: string): Promise<SlashCommandDto> {
-    return axios.get<SlashCommandDto>(`${BASE}/${id}`).then((r) => r.data);
+    return axios.get<SlashCommandDto>(`${BASE}/${id}`).then((r) => r.data.data);
   },
 
   create(payload: CreateSlashCommandPayload): Promise<SlashCommandDto> {
-    return axios.post<SlashCommandDto>(BASE, payload).then((r) => r.data);
+    return axios.post<SlashCommandDto>(BASE, payload).then((r) => r.data.data);
   },
 
   update(id: string, payload: UpdateSlashCommandPayload): Promise<SlashCommandDto> {
     return axios
       .patch<SlashCommandDto>(`${BASE}/${id}`, payload)
-      .then((r) => r.data);
+      .then((r) => r.data.data);
   },
 
   delete(id: string): Promise<void> {
@@ -63,6 +63,6 @@ export const slashCommandsClient = {
   toggle(id: string, isEnabled: boolean): Promise<SlashCommandDto> {
     return axios
       .patch<SlashCommandDto>(`${BASE}/${id}`, { isEnabled })
-      .then((r) => r.data);
+      .then((r) => r.data.data);
   },
 };
diff --git a/apps/client/src/features/acadenice/sync-blocks/services/sync-blocks-client.ts b/apps/client/src/features/acadenice/sync-blocks/services/sync-blocks-client.ts
index 08ab85ca..023d107b 100644
--- a/apps/client/src/features/acadenice/sync-blocks/services/sync-blocks-client.ts
+++ b/apps/client/src/features/acadenice/sync-blocks/services/sync-blocks-client.ts
@@ -21,15 +21,15 @@ const BASE = '/api/acadenice/sync-blocks';
 
 export const syncBlocksClient = {
   create(content: Record<string, unknown> = {}): Promise<SyncBlockDto> {
-    return axios.post<SyncBlockDto>(BASE, { content }).then((r) => r.data);
+    return axios.post<SyncBlockDto>(BASE, { content }).then((r) => r.data.data);
   },
 
   get(id: string): Promise<SyncBlockDto> {
-    return axios.get<SyncBlockDto>(`${BASE}/${id}`).then((r) => r.data);
+    return axios.get<SyncBlockDto>(`${BASE}/${id}`).then((r) => r.data.data);
   },
 
   update(id: string, content: Record<string, unknown>): Promise<SyncBlockDto> {
-    return axios.patch<SyncBlockDto>(`${BASE}/${id}`, { content }).then((r) => r.data);
+    return axios.patch<SyncBlockDto>(`${BASE}/${id}`, { content }).then((r) => r.data.data);
   },
 
   delete(id: string): Promise<void> {
@@ -37,6 +37,6 @@ export const syncBlocksClient = {
   },
 
   usages(id: string): Promise<SyncBlockUsageDto[]> {
-    return axios.get<SyncBlockUsageDto[]>(`${BASE}/${id}/usages`).then((r) => r.data);
+    return axios.get<SyncBlockUsageDto[]>(`${BASE}/${id}/usages`).then((r) => r.data.data);
   },
 };
diff --git a/apps/client/src/features/acadenice/templates-admin/services/templates-client.ts b/apps/client/src/features/acadenice/templates-admin/services/templates-client.ts
index c185e017..a38542e1 100644
--- a/apps/client/src/features/acadenice/templates-admin/services/templates-client.ts
+++ b/apps/client/src/features/acadenice/templates-admin/services/templates-client.ts
@@ -42,19 +42,19 @@ export const templatesClient = {
   list(opts: { category?: string; search?: string } = {}): Promise<TemplateDto[]> {
     return axios
       .get<TemplateDto[]>(BASE, { params: opts })
-      .then((r) => r.data);
+      .then((r) => r.data.data);
   },
 
   get(id: string): Promise<TemplateDto> {
-    return axios.get<TemplateDto>(`${BASE}/${id}`).then((r) => r.data);
+    return axios.get<TemplateDto>(`${BASE}/${id}`).then((r) => r.data.data);
   },
 
   create(payload: CreateTemplatePayload): Promise<TemplateDto> {
-    return axios.post<TemplateDto>(BASE, payload).then((r) => r.data);
+    return axios.post<TemplateDto>(BASE, payload).then((r) => r.data.data);
   },
 
   update(id: string, payload: UpdateTemplatePayload): Promise<TemplateDto> {
-    return axios.patch<TemplateDto>(`${BASE}/${id}`, payload).then((r) => r.data);
+    return axios.patch<TemplateDto>(`${BASE}/${id}`, payload).then((r) => r.data.data);
   },
 
   delete(id: string): Promise<void> {
@@ -67,10 +67,10 @@ export const templatesClient = {
   ): Promise<{ pageId: string; slugId: string }> {
     return axios
       .post<{ pageId: string; slugId: string }>(`${BASE}/${id}/instantiate`, payload)
-      .then((r) => r.data);
+      .then((r) => r.data.data);
   },
 
   setDefault(id: string): Promise<TemplateDto> {
-    return axios.patch<TemplateDto>(`${BASE}/${id}/default`).then((r) => r.data);
+    return axios.patch<TemplateDto>(`${BASE}/${id}/default`).then((r) => r.data.data);
   },
 };