AcadeNice/corentin_wakdo
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(admin): lien decouvrable vers la page de definition du PIN #28

Merged
Corentin merged 1 commit from fix/admin-link-pin-page into dev 2026-06-16 14:21:43 +02:00
Conversation 0 Commits 1 Files changed 2 +5
Corentin commented 2026-06-16 14:06:15 +02:00
Owner
Copy link

Finding LOW (audit 2026-06-16)

La page self-service /admin/profile/pin (definir/changer son PIN d'action sensible) existait et etait gardee, mais aucun lien n'y menait : joignable seulement par URL directe -> "self-service" non decouvrable.

Correctif

Lien ajoute dans le menu utilisateur de la topbar (layout.php), au-dessus de la deconnexion (separateur .divider). Reutilise les styles existants .dropdown-menu a. Assertion de rendu (/admin/profile/pin) ajoutee a DashboardControllerTest (hors des lignes touchees par #23 pour eviter tout conflit).

Tests verts, lint OK. Pas de label auto-merge.

## Finding LOW (audit 2026-06-16) La page self-service `/admin/profile/pin` (definir/changer son PIN d'action sensible) existait et etait gardee, mais **aucun lien** n'y menait : joignable seulement par URL directe -> "self-service" non decouvrable. ## Correctif Lien ajoute dans le menu utilisateur de la topbar (`layout.php`), au-dessus de la deconnexion (separateur `.divider`). Reutilise les styles existants `.dropdown-menu a`. Assertion de rendu (`/admin/profile/pin`) ajoutee a `DashboardControllerTest` (hors des lignes touchees par #23 pour eviter tout conflit). Tests verts, lint OK. Pas de label auto-merge.
Corentin added 1 commit 2026-06-16 14:06:15 +02:00
fix(admin): lien decouvrable vers la page de definition du PIN
All checks were successful
CI / secret-scan (push) Successful in 9s
Details
CI / static-tests (push) Successful in 38s
Details
CI / secret-scan (pull_request) Successful in 8s
Details
CI / php-lint (pull_request) Successful in 24s
Details
CI / static-tests (pull_request) Successful in 33s
Details
CI / auto-merge (push) Has been skipped
Details
CI / auto-merge (pull_request) Successful in 6s
Details
CI / php-lint (push) Successful in 20s
Details
943c6afe28 
La page self-service /admin/profile/pin (definir/changer son PIN d'action
sensible) existait mais n'etait liee nulle part : joignable seulement par URL
directe -> capacite non decouvrable. Ajout d'un lien dans le menu utilisateur
de la topbar (au-dessus de la deconnexion, separateur). Styles existants
(.dropdown-menu a, .divider). Assertion de rendu ajoutee a DashboardControllerTest.
Corentin merged commit 2cc499dc71 into dev 2026-06-16 14:21:43 +02:00
Corentin deleted branch fix/admin-link-pin-page 2026-06-16 14:21:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto-merge

Fusion automatique sur CI verte

No labels
auto-merge
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AcadeNice/corentin_wakdo#28
No description provided.
Delete branch "fix/admin-link-pin-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?