AcadeNice/corentin_wakdo
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(borne): composeur menu pilote par les slots /api/menus (P5 L2) #65

Merged
Corentin merged 1 commit from feat/p5-l2-composeur-slots into dev 2026-06-19 18:30:40 +02:00
Conversation 0 Commits 1 Files changed 5 +472 -556
Corentin commented 2026-06-19 18:28:28 +02:00
Owner
Copy link
No description provided.
Corentin added 1 commit 2026-06-19 18:28:29 +02:00
feat(borne): composeur menu pilote par les slots /api/menus (P5 L2)
All checks were successful
CI / secret-scan (pull_request) Successful in 12s
Details
CI / php-lint (pull_request) Successful in 26s
Details
CI / static-tests (pull_request) Successful in 50s
Details
CI / js-tests (pull_request) Successful in 33s
Details
CI / js-tests (push) Successful in 30s
Details
CI / secret-scan (push) Successful in 11s
Details
CI / php-lint (push) Successful in 26s
Details
CI / static-tests (push) Successful in 51s
Details
25f47a5074 
Le composeur de menu consomme desormais GET /api/menus/{id} au lieu de composer
librement a partir des categories (dette P4 #3). Burger impose (burger_product_id),
un pas par slot reel (drink/side/sauce, options resolues), format Normal/Maxi au
prix du menu.

- data.js : loadMenu(id) (detail + slots) ; loadProductsById (index produit par id,
  type 'produit' uniquement -> pas de collision avec les ids de menu).
- page-product-menu.js : reecrit slot-driven. Fonctions pures buildComposerSteps /
  buildMenuCartItem / selectionsComplete / composerIsViable. composition produite
  compatible avec page-cart.js et le panneau persistant L1 (slot_type -> champ).
- page-cart.js : rendu de composition tolerant aux champs absents ; libelle Maxi
  ("Format Maxi : +X") au lieu de "N grande(s)" devenu trompeur sous le forfait menu.
- tests : composer-slots.test.js + loadProductsById (data.test.js). 49/49 verts.

Revue adversariale (workflow, 14 findings / 12 confirmes) : must-fix integres --
SLOT_FIELD fait foi (slot_type hors drink/side/sauce ignore, l'enum DB autorise
dessert/extra -> plus de choix perdu) ; composerIsViable refuse d'ouvrir si burger
absent ou slot requis sans option (plus d'etape impassable) ; aria-hidden du fond
sous la modale ; role=dialog sur le conteneur ; overflow body sauvegarde/restaure.
Differes notes : multi-slots de meme type (menu famille), display_order vs maquette.
Corentin scheduled this pull request to auto merge when all checks succeed 2026-06-19 18:28:30 +02:00
Corentin merged commit 6e5a5f9334 into dev 2026-06-19 18:30:40 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto-merge

Fusion automatique sur CI verte

No labels
auto-merge
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AcadeNice/corentin_wakdo#65
No description provided.
Delete branch "feat/p5-l2-composeur-slots"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?