AcadeNice/corentin_wakdo
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(borne): memoisation loaders data.js + contraste a11y selection #69

Merged
Corentin merged 1 commit from chore/p5-cleanup-data-a11y into dev 2026-06-19 20:07:48 +02:00
Conversation 0 Commits 1 Files changed 2 +63 -75
Corentin commented 2026-06-19 20:04:39 +02:00
Owner
Copy link
No description provided.
Corentin added 1 commit 2026-06-19 20:04:41 +02:00
chore(borne): memoisation des loaders data.js + contraste a11y des etats selectionnes
All checks were successful
CI / secret-scan (pull_request) Successful in 11s
Details
CI / php-lint (pull_request) Successful in 21s
Details
CI / static-tests (pull_request) Successful in 45s
Details
CI / js-tests (pull_request) Successful in 26s
Details
f1f96b1278 
Cloture deux findings differes de la revue L1.

- data.js : loadCategories/loadProducts/loadProductsById/loadAllergens memoisent
  desormais la PROMESSE (et non le resultat). Les appelants concurrents au meme
  chargement (products.html : page-products + bandeau categories + panneau) partagent
  une seule requete /api/* au lieu d'en declencher plusieurs. Sur echec, la promesse
  est reinitialisee -> reessai possible (pas de cache d'erreur permanent).
- style.css : l'indicateur d'etat selectionne (.composer-card--selected) passe au
  jaune fonce + anneau renforce (le bandeau categories l'avait deja en L1) pour le
  contraste non-texte WCAG 1.4.11.

Tests JS inchanges : 64/64 verts (data.test.js couvre les loaders memoises).
Corentin scheduled this pull request to auto merge when all checks succeed 2026-06-19 20:04:41 +02:00
Corentin merged commit 6c431af197 into dev 2026-06-19 20:07:48 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto-merge

Fusion automatique sur CI verte

No labels
auto-merge
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AcadeNice/corentin_wakdo#69
No description provided.
Delete branch "chore/p5-cleanup-data-a11y"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?